Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the ESLint no-var rule in the src/shared/ folder #12436

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

Snuffleupagus
Copy link
Collaborator

Previously this rule has been enabled in the web/ folder, and in select files in the src/ sub-folders.
In this case, enabling of this rule didn't actually require any further code changes.

Please find additional details about the ESLint rule at https://eslint.org/docs/rules/no-var

@Snuffleupagus
Copy link
Collaborator Author

/botio lint

@pdfjsbot
Copy link

pdfjsbot commented Oct 2, 2020

From: Bot.io (Linux m4)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/6f94d6734dec2b8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 2, 2020

From: Bot.io (Windows)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/866b680b705df89/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 2, 2020

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/6f94d6734dec2b8/output.txt

Total script time: 2.18 mins

  • Lint: Passed

@pdfjsbot
Copy link

pdfjsbot commented Oct 2, 2020

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/866b680b705df89/output.txt

Total script time: 2.87 mins

  • Lint: Passed

src/shared/cffStandardStrings.js Outdated Show resolved Hide resolved
src/shared/message_handler.js Show resolved Hide resolved
Previously this rule has been enabled in the `web/` folder, and in select files in the `src/` sub-folders.
In this case, enabling of this rule didn't actually require any further code changes.

Please find additional details about the ESLint rule at https://eslint.org/docs/rules/no-var
@timvandermeij
Copy link
Contributor

/botio lint

@pdfjsbot
Copy link

pdfjsbot commented Oct 3, 2020

From: Bot.io (Windows)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 1

Live output at: http://54.215.176.217:8877/266b0f35ee2bcba/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 3, 2020

From: Bot.io (Linux m4)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/01405188dd7ad42/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 3, 2020

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/01405188dd7ad42/output.txt

Total script time: 2.26 mins

  • Lint: Passed

@pdfjsbot
Copy link

pdfjsbot commented Oct 3, 2020

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/266b0f35ee2bcba/output.txt

Total script time: 2.84 mins

  • Lint: Passed

@timvandermeij timvandermeij merged commit 76e96d4 into mozilla:master Oct 3, 2020
@timvandermeij
Copy link
Contributor

Thanks!

@Snuffleupagus Snuffleupagus deleted the src-shared-no-var branch October 3, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants