Re-factor how printing is triggered in the default viewer #12426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `PDFViewerApplication.triggerPrinting` method, which takes care of checking that printing is actually supported before calling `window.print`, to remove the need to duplicate that code in multiple places. Also, removes the `PDFViewerApplication.printing` getter since it's not really necessary any more.
Snuffleupagus
commented
Sep 30, 2020
| if (triggerAutoPrint) { | ||
| setTimeout(function () { | ||
| window.print(); | ||
| setTimeout(() => { |
There was a problem hiding this comment.
Note that I'm not actually sure if/why setTimeout is (still) necessary here!?
As far as I can tell, this was present already in PR #2839 which originally added the auto-print feature, hence there's probably a good reason for this.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/04119970d08e853/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/04119970d08e853/output.txt Total script time: 3.64 mins Published |
timvandermeij
approved these changes
Sep 30, 2020
|
Thank you for simplifying this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
PDFViewerApplication.triggerPrintingmethod, which takes care of checking that printing is actually supported before callingwindow.print, to remove the need to duplicate that code in multiple places.Also, removes the
PDFViewerApplication.printinggetter since it's not really necessary any more.