Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update escodegen to version 2.0 #12423

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Conversation

Snuffleupagus
Copy link
Collaborator

  • Update escodegen to version 2.0

    This release contains support for additional modern ECMAScript features, such as e.g. the nullish coalescing operator ?? and the optional chaining operator ?..

  • Add basic support for the optional chaining operator ?.

    For now we need to use a Babel-plugin, since part of our build system doesn't support this fully (e.g. Babel-loader, Webpack 4.x, and SystemJS).

    While the ?. operator will thus always be transpiled by Babel, even in modern builds, simply supporting it for development purposes seems like a step in the right direction.

    https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining

This release contains support for additional modern ECMAScript features, such as e.g. the nullish coalescing operator `??` and the optional chaining operator `?.`.
For now we need to use a Babel-plugin, since part of our build system doesn't support this fully (e.g. Babel-loader, Webpack 4.x, and SystemJS).

While the `?.` operator will thus always be transpiled by Babel, even in modern builds, simply supporting it for development purposes seems like a step in the right direction.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/75e76b49a8f8ef6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/75e76b49a8f8ef6/output.txt

Total script time: 3.56 mins

Published

@timvandermeij timvandermeij merged commit 8fa4e48 into mozilla:master Sep 29, 2020
@timvandermeij
Copy link
Contributor

Good idea!

@Snuffleupagus Snuffleupagus deleted the escodegen-2 branch September 30, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants