Compute the transformOrigin correctly, for negative values, when rendering AnnotationElements (bug 1627030)
#12409
Conversation
…ndering `AnnotationElement`s (bug 1627030) This changes the `transformOrigin` calculations in `AnnotationElement._createContainer` and `PopupAnnotationElement.render`, to ensure that e.g. the clickable area of annotations and/or popups are both positioned correctly. The problem occurs for *negative* values, since they're not negated correctly because of how the `transformOrigin` strings were build; see issue 12406 for a more in-depth explanation. Previously, for negative values, the `transformOrigin` strings would thus be ignored since they're not valid.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f9c19af64797f0a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/89d97fd529684ca/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/f9c19af64797f0a/output.txt Total script time: 27.38 mins
Image differences available at: http://54.67.70.0:8877/f9c19af64797f0a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/89d97fd529684ca/output.txt Total script time: 31.04 mins
Image differences available at: http://54.215.176.217:8877/89d97fd529684ca/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/cecf592b0a63955/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/cecf592b0a63955/output.txt Total script time: 3.53 mins Published |
|
Interesting bug; thanks for fixing this! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7a6be30ff8ff844/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/84bc3b21b8f529f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7a6be30ff8ff844/output.txt Total script time: 25.42 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/84bc3b21b8f529f/output.txt Total script time: 29.60 mins
|
This changes the
transformOrigincalculations inAnnotationElement._createContainerandPopupAnnotationElement.render, to ensure that e.g. the clickable area of annotations and/or popups are both positioned correctly.The problem occurs for negative values, since they're not negated correctly because of how the
transformOriginstrings were build; see issue #12406 for a more in-depth explanation. Previously, for negative values, thetransformOriginstrings would thus be ignored since they're not valid.Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1627030