Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing FBF tests, when running makeref, in Firefox as well #12372

Merged
merged 1 commit into from
Sep 13, 2020
Merged

Skip failing FBF tests, when running makeref, in Firefox as well #12372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,9 +467,14 @@ function checkFBF(task, results, browser, masterMode) {
continue;
}
if (r0Page.snapshot !== r1Page.snapshot) {
// The FBF tests fail intermittently in Google Chrome when run on the
// bots, ignoring `makeref` failures for now; see https://github.com/mozilla/pdf.js/pull/11491
if (masterMode && /chrom(e|ium)/i.test(browser)) {
// The FBF tests fail intermittently in Firefox and Google Chrome when run
// on the bots, ignoring `makeref` failures for now; see
// - https://github.com/mozilla/pdf.js/pull/12368
// - https://github.com/mozilla/pdf.js/pull/11491
//
// TODO: Figure out why this happens, so that we can remove the hack; see
// https://github.com/mozilla/pdf.js/issues/12371
if (masterMode) {
console.log(
"TEST-SKIPPED | forward-back-forward test " +
task.id +
Expand Down