Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the modification date to the current day when saving #12356

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

calixteman
Copy link
Contributor

No description provided.

@Snuffleupagus
Copy link
Collaborator

Perhaps slightly unrelated here, but isn't the default value in the getModificationDate function overly verbose?
Rather than

function getModificationDate(date = new Date(Date.now())) {
wouldn't just

function getModificationDate(date = new Date()) {

suffice according to the "No parameters" case in https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/Date#Syntax

@calixteman
Copy link
Contributor Author

Fixed, thx

@timvandermeij
Copy link
Contributor

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2020

From: Bot.io (Windows)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 1

Live output at: http://54.215.176.217:8877/18d894489dbb129/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2020

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/d8a9279e85ad1e7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2020

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/d8a9279e85ad1e7/output.txt

Total script time: 3.84 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Sep 9, 2020

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/18d894489dbb129/output.txt

Total script time: 5.19 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit eea97ea into mozilla:master Sep 9, 2020
@timvandermeij
Copy link
Contributor

Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants