Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltip if any in annotations layer #12333

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Add tooltip if any in annotations layer #12333

merged 1 commit into from
Oct 3, 2020

Conversation

calixteman
Copy link
Contributor

timvandermeij
timvandermeij reviewed Sep 6, 2020
View reviewed changes
src/display/annotation_layer.js Outdated Show resolved Hide resolved
src/display/annotation_layer.js Outdated Show resolved Hide resolved
src/core/annotation.js Outdated Show resolved Hide resolved
src/display/annotation_layer.js Show resolved Hide resolved
src/core/annotation.js Show resolved Hide resolved
@calixteman calixteman force-pushed the tooltip branch 2 times, most recently from b388f23 to 4bd80c5 Compare September 20, 2020 17:36
timvandermeij
timvandermeij reviewed Sep 24, 2020
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the two comments addressed.

src/display/annotation_layer.js Outdated Show resolved Hide resolved
src/display/annotation_layer.js Outdated Show resolved Hide resolved
@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Oct 2, 2020

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/b27de948d994d88/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 2, 2020

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/7be75189adfec86/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 2, 2020

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/b27de948d994d88/output.txt

Total script time: 27.22 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/b27de948d994d88/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Oct 2, 2020

From: Bot.io (Windows)

Failed

Full output at http://54.215.176.217:8877/7be75189adfec86/output.txt

Total script time: 32.22 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/7be75189adfec86/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Oct 3, 2020

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/6621cbc0a183d72/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 3, 2020

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/6621cbc0a183d72/output.txt

Total script time: 3.54 mins

Published

@timvandermeij timvandermeij merged commit 6ff1fe4 into mozilla:master Oct 3, 2020
@timvandermeij
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus left review comments

@brendandahl brendandahl brendandahl left review comments

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@calixteman @timvandermeij @pdfjsbot @brendandahl @Snuffleupagus