-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (basic) support for Stylelint, to allow linting of CSS files #12301
Conversation
e0cc673
to
23a04de
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0bf60b222c53b70/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/294b4b6ff1fe079/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/0bf60b222c53b70/output.txt Total script time: 2.03 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/294b4b6ff1fe079/output.txt Total script time: 2.76 mins
|
23a04de
to
6991727
Compare
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/ff46557933997c0/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/75ffb6fdbb5361f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/75ffb6fdbb5361f/output.txt Total script time: 2.13 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/ff46557933997c0/output.txt Total script time: 2.74 mins
|
f237f39
to
23db21d
Compare
This is *similar* to the existing linting for JavaScript files, but covers CSS files instead. While there's a lot of rules that could potentially be used, the main advantage of using Stylelint is that it has Prettier integration which means that we can automatically enforce a *consistent* style for our CSS files as well. As a proof of concept, this patch is purposely limited to: - Adding a simple rule, here `block-no-empty` is chosen; see https://stylelint.io/user-guide/rules/block-no-empty - Adding Prettier integration, to unify the style of our CSS files. Please find additional information at https://stylelint.io/
This was done automatically, using `gulp lint --fix`.
23db21d
to
8aa2718
Compare
/botio lint |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/516ebe6d0e81754/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3de35f4ddfe51c0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/3de35f4ddfe51c0/output.txt Total script time: 2.08 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/516ebe6d0e81754/output.txt Total script time: 2.79 mins
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/45d07791e6d0bb7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/45d07791e6d0bb7/output.txt Total script time: 3.43 mins Published |
This is a nice idea. Thanks! |
Add (basic) support for Stylelint, to allow linting of CSS files
This is similar to the existing linting for JavaScript files, but covers CSS files instead.
While there's a lot of rules that could potentially be used, the main advantage of using Stylelint is that it has Prettier integration which means that we can automatically enforce a consistent style for our CSS files as well.
As a proof of concept, this patch is purposely limited to:
block-no-empty
is chosen; see https://stylelint.io/user-guide/rules/block-no-emptyPlease find additional information at https://stylelint.io/