Update the indeterminate progressBar to the new design (PR 11077 follow-up) #12299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow-up) This special progressBar is only used in the (fortunately) rare case when a server doesn't provide a valid `Content-Length` header. Since this progressBar isn't normally seen, when testing the default viewer, it's certainly very easy to see why these CSS rules were missed during review. Furthermore, this patch also makes a couple of *small* progressBar CSS tweaks not related to the colours.
Snuffleupagus
force-pushed
the
progressBar-indeterminate
branch
from
dc92588 to
55e1dda
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.67.70.0:8877/c80533a54f1422f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c80533a54f1422f/output.txt Total script time: 3.42 mins Published |
timvandermeij
approved these changes
Aug 30, 2020
|
Nice find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This special progressBar is only used in the (fortunately) rare case when a server doesn't provide a valid
Content-Lengthheader. Since this progressBar isn't normally seen, when testing the default viewer, it's certainly very easy to see why these CSS rules were missed during review.Furthermore, this patch also makes a couple of small progressBar CSS tweaks not related to the colours.