Download, rather than opening, PDF attachments in Firefox (bug 1661259, PR 12286 follow-up) #12293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hments in Firefox (bug 1661259)" This reverts commit 1e5d4b6, since it unfortunately doesn't work in all situations. Please note that I did *successfully* test the patch in a local Firefox build, obviously with an ad blocker installed. However, I've now tested the *latest* Nightly-build with my default profile, and unfortunately I can still reproduce the bug there!?
…ntType when downloading PDF attachments This should provide better filetype detection when downloading PDF attachments in the viewer. Also, to avoid creating the "is PDF file" regular expression more than once it's extracted into a global constant instead.
…9, PR 12286 follow-up) Unfortunately the work-around implemented in PR 12286 didn't actually work in all cases, please refer to the previous commit messages. To prevent opening of PDF attachments from being completely broken for some users, we'll simply force-download them for now in MOZCENTRAL-builds to unbreak things. (Given that the "Open with" dialog now features a "Open with Firefox"-option, this is less bad than it previously would've been.)
Snuffleupagus
force-pushed
the
bug-1661259
branch
from
2dfa8c7 to
2a0de0b
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/dcbebfa17149fa0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/dcbebfa17149fa0/output.txt Total script time: 3.28 mins Published |
timvandermeij
approved these changes
Aug 27, 2020
|
Thank you; that does seem like the best approach for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the work-around implemented in PR #12286 didn't actually work in all cases, please refer to the previous commit messages.
To prevent opening of PDF attachments from being completely broken for some users, we'll simply force-download them for now in MOZCENTRAL-builds to unbreak things. (Given that the "Open with" dialog now features a "Open with Firefox"-option, this is less bad than it previously would've been.)
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1661259