Access the XRef/Catalog data correctly in the "GetStats"/"GetPageIndex" handlers in src/core/worker.js
#12276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/worker.js` Even though the code obviously works as-is, given that we have unit-tests for it, it still feels incorrect to just *assume* that the `XRef`-instance has all of its properties immediately available. Especially when (almost) all of the other handlers, in `src/core/worker.js`, protect their data accesses with appropriate `pdfManager.ensure` calls.
…`src/core/worker.js` Even though the code obviously works as-is, given that we have unit-tests for it, it still feels incorrect to just *assume* that the `Catalog`-instance has all of its properties immediately available. Especially when (almost) all of the other handlers, in `src/core/worker.js`, protect their data accesses with appropriate `pdfManager.ensure` calls.
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/32e5770729f5b9d/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6d098b166e5be77/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6d098b166e5be77/output.txt Total script time: 3.77 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/32e5770729f5b9d/output.txt Total script time: 4.87 mins
|
timvandermeij
approved these changes
Aug 25, 2020
|
I agree; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access the
XRefdata correctly in the "GetStats" handler insrc/core/worker.jsEven though the code obviously works as-is, given that we have unit-tests for it, it still feels incorrect to just assume that the
XRef-instance has all of its properties immediately available. Especially when (almost) all of the other handlers, insrc/core/worker.js, protect their data accesses with appropriatepdfManager.ensurecalls.Access the
Catalogdata correctly in the "GetPageIndex" handler insrc/core/worker.jsEven though the code obviously works as-is, given that we have unit-tests for it, it still feels incorrect to just assume that the
Catalog-instance has all of its properties immediately available. Especially when (almost) all of the other handlers, insrc/core/worker.js, protect their data accesses with appropriatepdfManager.ensurecalls.