Don't warn when navigating away from a modified form, if printing has occurred (issue 12262) #12265
Conversation
… occurred (issue 12262) This solution is obviously *not* perfect, since printing being cancelled will thus remove the warning as well. However, a similar problem already exists for saving, since the user may cancel that one as well. All-in-all, since way cannot really detect with absolute certainty that either saving or printing actually finished, this seems good enough for now.
|
Somewhat unrelated, however: Shouldn't the following method have been marked as "private", since I cannot imagine that it's correct to ever call it manually? pdf.js/src/display/annotation_storage.js Lines 77 to 84 in 9d7609d Please note that I'll happily add another commit here, fixing this, if we agree that it's a desirable change! |
…he `annotationStorage` parameter (PR 12241 follow-up) Obviously it doesn't make sense to call that method without providing an `AnnotationStorage`-instance, however we should ensure that doing so won't cause errors. Hence we need to check that `annotationStorage` is actually defined, before attempting to call its `resetModified` method.
I would say that's indeed desirable and most likely just something we missed in review. |
…PR 12241 follow-up) Since it shouldn't be called manually, we can just mark it as "private".
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6f9fcc75c340eca/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/9c1b76667f00d74/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6f9fcc75c340eca/output.txt Total script time: 3.79 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/9c1b76667f00d74/output.txt Total script time: 4.69 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/49e00b657fafc07/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/49e00b657fafc07/output.txt Total script time: 3.27 mins Published |
|
Thank you for helping out with polishing the form fill implementation! |
This solution is obviously not perfect, since printing being cancelled will thus remove the warning as well. However, a similar problem already exists for saving, since the user may cancel that one as well.
All-in-all, since way cannot really detect with absolute certainty that either saving or printing actually finished, this seems good enough for now.
Fixes #12262