Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reference testing for printing #12230

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Implement reference testing for printing #12230

merged 2 commits into from
Aug 18, 2020

Conversation

timvandermeij
Copy link
Contributor

Fixes #12225.

@timvandermeij timvandermeij changed the title Implement reference tests for printing Implement reference testing for printing Aug 17, 2020
@timvandermeij timvandermeij added the Gecko 81 Tracking work planned for Form Fill in Shirley 81 release label Aug 17, 2020
@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/2fa64ec89c2847f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/3a18bd7990bcf9e/output.txt

Snuffleupagus
Snuffleupagus reviewed Aug 17, 2020
View reviewed changes
test/driver.js Outdated Show resolved Hide resolved
@timvandermeij
Copy link
Contributor Author

Note to self: update https://github.com/mozilla/pdf.js/wiki/Contributing after this patch lands and include any missing types (forms).

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/2fa64ec89c2847f/output.txt

Total script time: 27.23 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/2fa64ec89c2847f/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.215.176.217:8877/3a18bd7990bcf9e/output.txt

Total script time: 29.05 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/3a18bd7990bcf9e/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, modulo one comment; thanks for doing this!

test/driver.js Outdated Show resolved Hide resolved
@timvandermeij
Implement reference testing for printing
8ccf09d 
This commit includes support for rendering pages in printing mode,
which, when combined with annotation storage data, is useful for testing
if form data is correctly rendered onto the printed canvas.
@timvandermeij
Include reference tests for text/choice/button widget printing
483efed
@timvandermeij
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/027b8645d2f6543/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/785b49282fa252e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/785b49282fa252e/output.txt

Total script time: 25.28 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/027b8645d2f6543/output.txt

Total script time: 27.17 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@timvandermeij timvandermeij merged commit b52b36f into mozilla:master Aug 18, 2020
@timvandermeij timvandermeij deleted the reference-test-print branch August 18, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
form-acroform Gecko 81 Tracking work planned for Form Fill in Shirley 81 release test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement reference testing for printing
3 participants
@timvandermeij @pdfjsbot @Snuffleupagus