-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test-case for issue 4398 #12187
Conversation
Issue 4398 was fixed by PR 4437, however a test-case wasn't included as far as I can tell. Given that PR 12186 is now in the process of re-factoring that code, adding a test-case cannot hurt as far as I'm concerned.
e491b90
to
128e41d
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/eca0bf4f27ec829/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/a0b611498bbad87/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/eca0bf4f27ec829/output.txt Total script time: 26.91 mins
Image differences available at: http://54.67.70.0:8877/eca0bf4f27ec829/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/a0b611498bbad87/output.txt Total script time: 29.01 mins
Image differences available at: http://54.215.176.217:8877/a0b611498bbad87/reftest-analyzer.html#web=eq.log |
Good idea; thanks! |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0b78819d554f818/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 2 Live output at: http://54.215.176.217:8877/c6bcaaece82001b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/0b78819d554f818/output.txt Total script time: 25.19 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/c6bcaaece82001b/output.txt Total script time: 28.81 mins
|
Issue #4398 was fixed by PR #4437, however a test-case wasn't included as far as I can tell. Given that PR #12186 is now in the process of re-factoring that code, adding a test-case cannot hurt as far as I'm concerned.