Do the AppOptions.get("printResolution") lookup once in web/app.js , when initializing PDFPrintServiceFactory-instances, rather than for every printed page
#12174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d827bf06eef7509/output.txt |
Snuffleupagus
changed the title
AppOptions.get("printResolution") lookup once in web/app.js , when initializing PDFPrintServiceFactory-instances, rather then for every printed pageAppOptions.get("printResolution") lookup once in web/app.js , when initializing PDFPrintServiceFactory-instances, rather than for every printed page
…`, when initializing `PDFPrintServiceFactory`-instances, rather than for every printed page There's really no point in repeating these lookups over and over, since the value should be constant for the duration of one print invocation anyway.
Snuffleupagus
force-pushed
the
AppOptions-printResolution
branch
from
d47a878 to
97d796e
Compare
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d827bf06eef7509/output.txt Total script time: 3.40 mins Published |
timvandermeij
approved these changes
Aug 5, 2020
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's really no point in repeating these lookups over and over, since the value should be constant for the duration of one print invocation anyway.