[src/core/worker.js] Remove a useless Promise handler from the pdfManagerReady function
#12135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagerReady` function Looking carefully at this code, you'll notice that the `loadDocument` function has no less than *three* Promise handling functions. This obviously makes no sense, since a Promise can only have one resolve and one reject handler. Hence the final `onFailure`-case is unreachable, which only serves to add confusion when reading the code. Note that this code has been re-factored more than once over the years, but it seems as if this may even have been incorrect already in PR 3310 (and no-one have noticed for seven years :-).
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1f5ebfef2b4a7b9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/666d76c4bc99ffb/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/1f5ebfef2b4a7b9/output.txt Total script time: 26.69 mins
Image differences available at: http://54.67.70.0:8877/1f5ebfef2b4a7b9/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/666d76c4bc99ffb/output.txt Total script time: 29.84 mins
Image differences available at: http://54.215.176.217:8877/666d76c4bc99ffb/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Jul 28, 2020
|
Ha, nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking carefully at this code, you'll notice that the
loadDocumentfunction has no less than three Promise handling functions. This obviously makes no sense, since a Promise can only have one resolve and one reject handler.Hence the final
onFailure-case is unreachable, which only serves to add confusion when reading the code. Note that this code has been re-factored more than once over the years, but it seems as if this may even have been incorrect already in PR #3310 (and no-one have noticed for seven years :-).Smaller diff with https://github.com/mozilla/pdf.js/pull/12135/files?diff=split&w=1