Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-minor] Allow loading pdf fonts into another document. #12131
[api-minor] Allow loading pdf fonts into another document. #12131
Changes from all commits
9b16b8e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is completely wrong, since
global
isn't actually defined other than in Node.js and these unit-tests now fail in browsers withReferenceError: global is not defined ...
Fixing that locally, however, still causes these tests to fail, now with
TypeError: canvas.getContext is not a function ...
in browsers.When reviewing this, I simply assumed that the new unit-tests were actually tested and thus working, but looking at them again I'm no longer sure that they're doing the right thing in general unfortunately. (E.g. the
ownerDocument
probably needs to be a validHTMLDocument
-instance, rather than a regular object.)It's strange that this didn't cause the bots to fail, but it's clear from the logs that these new tests didn't even run. Unfortunately I cannot see an immediate fix for the unit-tests, and just removing the unit-tests seem like the wrong approach.
@timvandermeij Can you please back out this patch, since this shouldn't have landed as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch is now reverted. It's indeed really not great that Jasmine doesn't even run the test and therefore the bots think all is fine. I'll try to find out why that happens since we want to get a failed test if that ever happens.