Ensure that PDFImage.buildImage won't accidentally swallow errors, e.g. from ColorSpace parsing (issue 6707, PR 11601 follow-up)
#12000
Conversation
…e.g. from ColorSpace parsing (issue 6707, PR 11601 follow-up) Because of a really stupid `Promise`-related mistake on my part, when re-factoring `PDFImage.buildImage` during the `NativeImageDecoder` removal, we're no longer re-throwing errors occuring during image parsing/decoding as intended. The result is that some (fairly) corrupt documents will never finish loading, and unfortunately there were apparently no sufficiently corrupt images in the test-suite to catch this.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f2e1253af994ca4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/b7080f93acff001/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/f2e1253af994ca4/output.txt Total script time: 25.82 mins
Image differences available at: http://54.67.70.0:8877/f2e1253af994ca4/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/b7080f93acff001/output.txt Total script time: 28.90 mins
Image differences available at: http://54.215.176.217:8877/b7080f93acff001/reftest-analyzer.html#web=eq.log |
|
This is a regression that I stumbled upon while working on master...Snuffleupagus:cache-ColorSpace-locally :-) |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2ea7e05732026b7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2ea7e05732026b7/output.txt Total script time: 3.45 mins Published |
|
Thank you for finding and fixing this, and good that the test coverage is extended to avoid this in the future! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b404a978ea5d4f8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/3d7fbf9ae4d14d0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b404a978ea5d4f8/output.txt Total script time: 24.06 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/3d7fbf9ae4d14d0/output.txt Total script time: 26.04 mins
|
Because of a really stupid
Promise-related mistake on my part, when re-factoringPDFImage.buildImageduring theNativeImageDecoderremoval, we're no longer re-throwing errors occuring during image parsing/decoding as intended.The result is that some (fairly) corrupt documents will never finish loading, and unfortunately there were apparently no sufficiently corrupt images in the test-suite to catch this.