Change the loadedChunks property, on ChunkedStream instances, from an Array to a Set
#11972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m an Array to a Set In the old code the use of an Array meant that we had to *manually* track the `numChunksLoaded` property, given that simply using the Array `length` wouldn't have worked since there's no guarantee that the data is loaded in order when e.g. range requests are in use. Tracking closely related state *separately* in this manner never seem like a good idea, and we can now instead utilize a Set to avoid that.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/59bf4009a40def1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/29994bf8189c2ee/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/59bf4009a40def1/output.txt Total script time: 25.87 mins
Image differences available at: http://54.67.70.0:8877/59bf4009a40def1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/29994bf8189c2ee/output.txt Total script time: 30.19 mins
Image differences available at: http://54.215.176.217:8877/29994bf8189c2ee/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Jun 5, 2020
|
Less is more when it comes to tracking related state. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old code the use of an Array meant that we had to manually track the
numChunksLoadedproperty, given that simply using the Arraylengthwouldn't have worked since there's no guarantee that the data is loaded in order when e.g. range requests are in use.Tracking closely related state separately in this manner never seem like a good idea, and we can now instead utilize a Set to avoid that.