[Regression] Ensure that "Highlight All" is propagated to all pages for 'findagain' events where the findbar was previously closed (PR 10100 follow-up) #10196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/820137ecc848e71/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/820137ecc848e71/output.txt Total script time: 2.99 mins Published |
…or 'findagain' events where the findbar was previously closed (PR 10100 follow-up) **STR:** 1. Open the default viewer, with the `tracemonkey` file. 2. Open the findbar, and search for "trace". 3. Enable the "Highlight All" option. 4. Close the findbar. 5. Re-open the findbar, and click on the "findNext" button. 6. Scroll down to the *second* page of the document. **ER:** Since "Highlight All" is active, all matches on the *second* page should be highlighted. **AR:** No matches are highlighted on the *second* page.
Snuffleupagus
force-pushed
the
findbarclose-findagain-highlightAll
branch
from
d347c20 to
96abb4b
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/cb1966e72f59f34/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/cb1966e72f59f34/output.txt Total script time: 3.01 mins Published |
timvandermeij
approved these changes
Oct 29, 2018
|
Thank you for the follow-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STR:
tracemonkeyfile.ER:
Since "Highlight All" is active, all matches on the second page should be highlighted.
AR:
No matches are highlighted on the second page.
/cc @timvandermeij I should have caught this when working on PR #10100, but I obviously didn't; sorry about that!