Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused mainContainer parameter from the Toolbar constructor #10136

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

Snuffleupagus
Copy link
Collaborator

Looking at the history of this code, this parameter has never been used.
I'm guessing that most likely the code in web/toolbar.js began life as a copy of web/secondary_toolbar.js, which would probably explain why that parameter exists.

…uctor

Looking at the history of this code, this parameter has never been used.
I'm guessing that most likely the code in `web/toolbar.js` began life as a copy of `web/secondary_toolbar.js`, which would probably explain why that parameter exists.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Oct 5, 2018

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1c11ea47a2cb6af/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 5, 2018

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/1c11ea47a2cb6af/output.txt

Total script time: 2.93 mins

Published

@timvandermeij timvandermeij merged commit 3c6d0a8 into mozilla:master Oct 5, 2018
@timvandermeij
Copy link
Contributor

Good find; thank you for making this a bit easier!

@Snuffleupagus Snuffleupagus deleted the toolbar-signature branch October 5, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants