Attempt to simplify the fileattachmentannotation event dispatching
#10119
Conversation
This attempts to reduced the level of indirection, and the amount of code, when dispatching `fileattachmentannotation` events, by removing the `PDFLinkService.onFileAttachmentAnnotation` method and just accessing `PDFLinkService.eventBus` directly in the `FileAttachmentAnnotationElement` constructor. Given that other properties, such as `externalLinkTarget`/`externalLinkRel`, are already being accessed directly this pattern seems fine here as well.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7d761ef8032b030/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/f977e1b19efc36b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7d761ef8032b030/output.txt Total script time: 19.73 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/f977e1b19efc36b/output.txt Total script time: 24.15 mins
Image differences available at: http://54.215.176.217:8877/f977e1b19efc36b/reftest-analyzer.html#web=eq.log |
|
Hopefully just a Windows intermittent... /botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/03ec27a7a072146/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/03ec27a7a072146/output.txt Total script time: 23.96 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/565911aedcbce8b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/565911aedcbce8b/output.txt Total script time: 2.93 mins Published |
|
Much simpler; thanks! |
This attempts to reduced the level of indirection, and the amount of code, when dispatching
fileattachmentannotationevents, by removing thePDFLinkService.onFileAttachmentAnnotationmethod and just accessingPDFLinkService.eventBusdirectly in theFileAttachmentAnnotationElementconstructor.Given that other properties, such as
externalLinkTarget/externalLinkRel, are already being accessed directly this pattern seems fine here as well.