Adding chunkname to async loaded code #10015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/display/api.js
Outdated
| @@ -75,7 +75,7 @@ if (typeof PDFJSDev !== 'undefined' && PDFJSDev.test('GENERIC')) { | |||
| worker = __non_webpack_require__('./pdf.worker.js'); | |||
| } | |||
| callback(worker.WorkerMessageHandler); | |||
| }); | |||
| }, null, 'pdfWorker'); | |||
There was a problem hiding this comment.
pdfjsWorker seems like a slightly better choice here, since it would be consistent with the name/alias used in the bundles.
There was a problem hiding this comment.
thanks, updated!
|
Looks good to me. Could you please squash the commits into one commit? Refer to https://github.com/mozilla/pdf.js/wiki/Squashing-Commits for how to do that easily. |
Better name
cheryly279
force-pushed
the
add-chunkname
branch
from
96878e5 to
29c0ea1
Compare
|
Squashed. |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/cd73239fc3805dd/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/cd73239fc3805dd/output.txt Total script time: 24.75 mins
|
timvandermeij
approved these changes
Aug 29, 2018
|
Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement, see: #10002