Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a UI for multiple phrase search #7368

Closed
timvandermeij opened this issue May 27, 2016 · 3 comments
Closed

Implement a UI for multiple phrase search #7368

timvandermeij opened this issue May 27, 2016 · 3 comments

Comments

@timvandermeij
Copy link
Contributor

PR #5579 implemented multiple phrase search, but as of now this is only accessible through the #search= URL parameter. It would be nice have a UI for this. We need to adapt our current find bar to add a checkbox for phrase search, but this also involves integration for the Firefox add-on.

@ribeaud
Copy link

ribeaud commented Dec 5, 2016

See #7870 for corresponding pull request.

@Snuffleupagus
Copy link
Collaborator

Unless "phrase search" would also be generally implemented in the native Firefox browser findbar[1], this really cannot be implemented since it would result in inconsistent find UI behaviour.
Note in particular that for PDF files displayed in e.g. <iframe> tags the PDFFindBar implementation is still, by necessity, used even in Firefox.


[1] The PDF Viewer in Firefox, which is built on the general PDF.js library, (normally) uses the browser findbar.

@Snuffleupagus
Copy link
Collaborator

Given that this, as outlined in #7368 (comment), is basically blocked on similar functionality existing for regular searching in Firefox itself, is it really meaningful to keep this issue open indefinitely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants