Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS - actions are not executed in a form #13132

Closed
calixteman opened this issue Mar 23, 2021 · 1 comment · Fixed by #13133
Closed

JS - actions are not executed in a form #13132

calixteman opened this issue Mar 23, 2021 · 1 comment · Fixed by #13133
Assignees
@calixteman
Labels
core form-js

Comments

@calixteman
Copy link
Contributor

calixteman commented Mar 23, 2021 •
edited
Loading

Attach (recommended) or Link to PDF file here:
Original pdf:
https://assets.publishing.service.gov.uk/government/uploads/system/uploads/attachment_data/file/866023/IHT205_2004-2006.pdf

A copy: IHT205_2004-2006.pdf

Configuration:

  • Web browser and its version: firefox nightly
  • Operating system and its version: linux
  • PDF.js version:
  • Is a browser extension:

Steps to reproduce the problem:

  1. Put some numbers into fields for item 11 at page 2

What is the expected behavior? (add screenshot)
Field A under 11.11 should contain the sum of numbers entered in field 11.*

What went wrong? (add screenshot)
Nothing in field A.
@calixteman calixteman self-assigned this Mar 23, 2021
@calixteman
Copy link
Contributor Author

The problem is that CO (Calculation Order) contains some references to fields which contain themselves some annotations (annotations and fields are not merged).
There are some fields which are just containers for other fields, their type is an empty string and there is nothing in spec about that:
https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/AcrobatDC_js_api_reference.pdf#page=442
Additionally, annotations can inherit their actions from the parent fields.
For these reasons a lot of actions are not executed at all.

calixteman added a commit to calixteman/pdf.js that referenced this issue Mar 23, 2021
@calixteman
JS - Handle correctly hierarchy of fields
63f5f8e 
  - it aims to fix mozilla#13132;
  - annotations can inherit their actions from the parent field;
  - there are some fields which act as a container for other fields:
    - they can be access through js so need to add them with an empty type (nothing in the spec about that but checked in Acrobat);
    - calculation order list (CO) can reference them so need make them through this.getField;
    - getArray method must return kids.
  - field values are number, string, ... depending of their type but nothing in the spec on how to know what's the type:
    - according to the comment for Canonical Format: https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#page=461
    - it seems that this "type" can be guessed from js action Format (when setting a type in Acrobat DC, the only affected thing is this action).
  - util.scand with an empty string returns the current date.
@calixteman calixteman mentioned this issue Mar 23, 2021
Merged
calixteman added a commit to calixteman/pdf.js that referenced this issue Mar 24, 2021
@calixteman
JS - Handle correctly hierarchy of fields
79437f4 
  - it aims to fix mozilla#13132;
  - annotations can inherit their actions from the parent field;
  - there are some fields which act as a container for other fields:
    - they can be access through js so need to add them with an empty type (nothing in the spec about that but checked in Acrobat);
    - calculation order list (CO) can reference them so need make them through this.getField;
    - getArray method must return kids.
  - field values are number, string, ... depending of their type but nothing in the spec on how to know what's the type:
    - according to the comment for Canonical Format: https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#page=461
    - it seems that this "type" can be guessed from js action Format (when setting a type in Acrobat DC, the only affected thing is this action).
  - util.scand with an empty string returns the current date.
calixteman added a commit to calixteman/pdf.js that referenced this issue Mar 24, 2021
@calixteman
JS - Handle correctly hierarchy of fields
53a742b 
  - it aims to fix mozilla#13132;
  - annotations can inherit their actions from the parent field;
  - there are some fields which act as a container for other fields:
    - they can be access through js so need to add them with an empty type (nothing in the spec about that but checked in Acrobat);
    - calculation order list (CO) can reference them so need make them through this.getField;
    - getArray method must return kids.
  - field values are number, string, ... depending of their type but nothing in the spec on how to know what's the type:
    - according to the comment for Canonical Format: https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#page=461
    - it seems that this "type" can be guessed from js action Format (when setting a type in Acrobat DC, the only affected thing is this action).
  - util.scand with an empty string returns the current date.
calixteman added a commit to calixteman/pdf.js that referenced this issue Mar 24, 2021
@calixteman
JS - Handle correctly hierarchy of fields
3e547f9 
  - it aims to fix mozilla#13132;
  - annotations can inherit their actions from the parent field;
  - there are some fields which act as a container for other fields:
    - they can be access through js so need to add them with an empty type (nothing in the spec about that but checked in Acrobat);
    - calculation order list (CO) can reference them so need make them through this.getField;
    - getArray method must return kids.
  - field values are number, string, ... depending of their type but nothing in the spec on how to know what's the type:
    - according to the comment for Canonical Format: https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#page=461
    - it seems that this "type" can be guessed from js action Format (when setting a type in Acrobat DC, the only affected thing is this action).
  - util.scand with an empty string returns the current date.
calixteman added a commit to calixteman/pdf.js that referenced this issue Mar 24, 2021
@calixteman
JS - Handle correctly hierarchy of fields
50bc3b7 
  - it aims to fix mozilla#13132;
  - annotations can inherit their actions from the parent field;
  - there are some fields which act as a container for other fields:
    - they can be access through js so need to add them with an empty type (nothing in the spec about that but checked in Acrobat);
    - calculation order list (CO) can reference them so need make them through this.getField;
    - getArray method must return kids.
  - field values are number, string, ... depending of their type but nothing in the spec on how to know what's the type:
    - according to the comment for Canonical Format: https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#page=461
    - it seems that this "type" can be guessed from js action Format (when setting a type in Acrobat DC, the only affected thing is this action).
  - util.scand with an empty string returns the current date.
calixteman added a commit to calixteman/pdf.js that referenced this issue Mar 24, 2021
@calixteman
JS - Handle correctly hierarchy of fields
364558d 
  - it aims to fix mozilla#13132;
  - annotations can inherit their actions from the parent field;
  - there are some fields which act as a container for other fields:
    - they can be access through js so need to add them with an empty type (nothing in the spec about that but checked in Acrobat);
    - calculation order list (CO) can reference them so need make them through this.getField;
    - getArray method must return kids.
  - field values are number, string, ... depending of their type but nothing in the spec on how to know what's the type:
    - according to the comment for Canonical Format: https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#page=461
    - it seems that this "type" can be guessed from js action Format (when setting a type in Acrobat DC, the only affected thing is this action).
  - util.scand with an empty string returns the current date.
calixteman added a commit to calixteman/pdf.js that referenced this issue Mar 29, 2021
@calixteman
JS - Handle correctly hierarchy of fields
556936c 
  - it aims to fix mozilla#13132;
  - annotations can inherit their actions from the parent field;
  - there are some fields which act as a container for other fields:
    - they can be access through js so need to add them with an empty type (nothing in the spec about that but checked in Acrobat);
    - calculation order list (CO) can reference them so need make them through this.getField;
    - getArray method must return kids.
  - field values are number, string, ... depending of their type but nothing in the spec on how to know what's the type:
    - according to the comment for Canonical Format: https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#page=461
    - it seems that this "type" can be guessed from js action Format (when setting a type in Acrobat DC, the only affected thing is this action).
  - util.scand with an empty string returns the current date.
brendandahl pushed a commit that referenced this issue Mar 30, 2021
@calixteman
JS - Handle correctly hierarchy of fields (#13133)
84d7ccc 
* JS - Handle correctly hierarchy of fields
  - it aims to fix #13132;
  - annotations can inherit their actions from the parent field;
  - there are some fields which act as a container for other fields:
    - they can be access through js so need to add them with an empty type (nothing in the spec about that but checked in Acrobat);
    - calculation order list (CO) can reference them so need make them through this.getField;
    - getArray method must return kids.
  - field values are number, string, ... depending of their type but nothing in the spec on how to know what's the type:
    - according to the comment for Canonical Format: https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#page=461
    - it seems that this "type" can be guessed from js action Format (when setting a type in Acrobat DC, the only affected thing is this action).
  - util.scand with an empty string returns the current date.
@calixteman calixteman mentioned this issue Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calixteman calixteman

Labels
core form-js
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JS - Handle correctly hierarchy of fields calixteman/pdf.js
3 participants
@marco-c @timvandermeij @calixteman