Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo/error in /src/display/annotation_layer.js with the "MouseUp" eventName #12895

Closed
Snuffleupagus opened this issue Jan 23, 2021 · 0 comments
Assignees
Labels

Comments

@Snuffleupagus
Copy link
Collaborator

In the following spots a "MouseUp" eventName is being used, which does look inconsistent considering that the "Mouse Down"/"Mouse Enter"/"Mouse Exit" eventNames all have a space in them.
Is this inconsistency actually expected, or is it a simple typo? If the former, then a comment explaining why would be appropriate; otherwise we should just fix this :-)

/cc @calixteman

calixteman added a commit to calixteman/pdf.js that referenced this issue Jan 23, 2021
calixteman added a commit to calixteman/pdf.js that referenced this issue Jan 23, 2021
phuocng pushed a commit to react-pdf-viewer/pdf.js that referenced this issue May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants