-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the webpack-stream
dependency
#11996
Comments
This is now becoming more of a problem, and it should ideally be prioritized, since I recently tried to add support for optional chaining but unfortunately ran into errors in |
This dependency is now updated to the most recent version in #12397. However, given that's it's a very inactively maintained dependency I also think we should get rid of it. Moreover, we only seem to be using it in one place in the Gulpfile... |
Now that we're using Webpack 5, the dependency got updated and there was more development on their GitHub page, do we still want to do this? I guess we could make https://github.com/mozilla/pdf.js/blob/master/package.json#L61 use |
Given that the Webpack upgrade itself wasn't actually blocked by the
To me, this all depends on whether or not they'll try to re-introduce the broken caching mechanism (which originally forced us to pin the version number).
I suppose that could work, as long as we remember to check |
With PR #11436 we became locked at a particular (older) version of the
webpack-stream
dependency, because of bugs in the latest versions; see #11436 (comment) for details.Looking at the GitHub-page for
webpack-stream
, it unfortunately seems that the project may be unmaintained/dead at this point given that the latest commit was in 2018.Hence, rather than trying to update
webpack-stream
it's probably better to attempt to replace it completely instead (possibly with our own code if necessary) to ensure that we'll be able to e.g. update to Webpack 5 when it's released (which will likely be needed to properly support new ECMAScript features).The text was updated successfully, but these errors were encountered: