Merge pull request #12201 from brendandahl/enable-forms

Enable renderInteractiveForms by default.
mozilla · Aug 12, 2020 · e50cb4c · e50cb4c
2 parents 7edc5cb + da62be0
commit e50cb4c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/extensions/chromium/preferences_schema.json b/extensions/chromium/preferences_schema.json
@@ -149,7 +149,7 @@
     },
     "renderInteractiveForms": {
       "type": "boolean",
-      "default": false
+      "default": true
     },
     "enablePermissions": {
       "type": "boolean",

diff --git a/web/app.js b/web/app.js
@@ -1415,8 +1415,14 @@ const PDFViewerApplication = {
       this.setTitle(contentDispositionFilename);
     }
 
-    if (info.IsAcroFormPresent) {
-      console.warn("Warning: AcroForm/XFA is not supported");
+    if (info.IsXFAPresent) {
+      console.warn("Warning: XFA is not supported");
+      this._delayedFallback(UNSUPPORTED_FEATURES.forms);
+    } else if (
+      info.IsAcroFormPresent &&
+      !this.pdfViewer.renderInteractiveForms
+    ) {
+      console.warn("Warning: AcroForm support is not enabled");
       this._delayedFallback(UNSUPPORTED_FEATURES.forms);
     }
 

diff --git a/web/app_options.js b/web/app_options.js
@@ -121,7 +121,7 @@ const defaultOptions = {
   },
   renderInteractiveForms: {
     /** @type {boolean} */
-    value: false,
+    value: true,
     kind: OptionKind.VIEWER + OptionKind.PREFERENCE,
   },
   sidebarViewOnLoad: {