Use the same SVG images, in the default viewer, regardless of the CSS…

… theme As mentioned in https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support, PDF.js version `2.6.347` is the last release with IE 11/Edge support. Hence we should now be able to reduce unnecessary duplication in the default viewer image resources, note the files in the `web/images/` folder with a `-dark` suffix, by using only *one* SVG-image for each icon and letting the `background-color` depend on the CSS theme instead. For the `gulp mozcentral` build-target, the resulting `web/images/` folder is reduced from `43 997` to `28 566` bytes (~35 percent). *Please note:* I don't really know if this implementation is necessarily the *best* solution, but it seems to work well enough in e.g. Firefox Nightly and Google Chrome Beta as far as my testing goes.
mozilla · Nov 29, 2020 · d5df6d1 · d5df6d1
1 parent e072f1d
commit d5df6d1
Show file tree

Hide file tree

Showing 35 changed files with 79 additions and 208 deletions.
diff --git a/web/images/findbarButton-next-dark.svg b/web/images/findbarButton-next-dark.svg
diff --git a/web/images/findbarButton-previous-dark.svg b/web/images/findbarButton-previous-dark.svg
diff --git a/web/images/secondaryToolbarButton-documentProperties-dark.svg b/web/images/secondaryToolbarButton-documentProperties-dark.svg
diff --git a/web/images/secondaryToolbarButton-firstPage-dark.svg b/web/images/secondaryToolbarButton-firstPage-dark.svg
diff --git a/web/images/secondaryToolbarButton-handTool-dark.svg b/web/images/secondaryToolbarButton-handTool-dark.svg
diff --git a/web/images/secondaryToolbarButton-lastPage-dark.svg b/web/images/secondaryToolbarButton-lastPage-dark.svg
diff --git a/web/images/secondaryToolbarButton-rotateCcw-dark.svg b/web/images/secondaryToolbarButton-rotateCcw-dark.svg
diff --git a/web/images/secondaryToolbarButton-rotateCw-dark.svg b/web/images/secondaryToolbarButton-rotateCw-dark.svg
diff --git a/web/images/secondaryToolbarButton-scrollHorizontal-dark.svg b/web/images/secondaryToolbarButton-scrollHorizontal-dark.svg
diff --git a/web/images/secondaryToolbarButton-scrollVertical-dark.svg b/web/images/secondaryToolbarButton-scrollVertical-dark.svg
diff --git a/web/images/secondaryToolbarButton-scrollWrapped-dark.svg b/web/images/secondaryToolbarButton-scrollWrapped-dark.svg
diff --git a/web/images/secondaryToolbarButton-selectTool-dark.svg b/web/images/secondaryToolbarButton-selectTool-dark.svg
diff --git a/web/images/secondaryToolbarButton-spreadEven-dark.svg b/web/images/secondaryToolbarButton-spreadEven-dark.svg
diff --git a/web/images/secondaryToolbarButton-spreadNone-dark.svg b/web/images/secondaryToolbarButton-spreadNone-dark.svg
diff --git a/web/images/secondaryToolbarButton-spreadOdd-dark.svg b/web/images/secondaryToolbarButton-spreadOdd-dark.svg
diff --git a/web/images/toolbarButton-bookmark-dark.svg b/web/images/toolbarButton-bookmark-dark.svg
diff --git a/web/images/toolbarButton-download-dark.svg b/web/images/toolbarButton-download-dark.svg
diff --git a/web/images/toolbarButton-menuArrow-dark.svg b/web/images/toolbarButton-menuArrow-dark.svg
diff --git a/web/images/toolbarButton-openFile-dark.svg b/web/images/toolbarButton-openFile-dark.svg
diff --git a/web/images/toolbarButton-pageDown-dark.svg b/web/images/toolbarButton-pageDown-dark.svg
diff --git a/web/images/toolbarButton-pageUp-dark.svg b/web/images/toolbarButton-pageUp-dark.svg
diff --git a/web/images/toolbarButton-presentationMode-dark.svg b/web/images/toolbarButton-presentationMode-dark.svg
diff --git a/web/images/toolbarButton-print-dark.svg b/web/images/toolbarButton-print-dark.svg
diff --git a/web/images/toolbarButton-search-dark.svg b/web/images/toolbarButton-search-dark.svg
diff --git a/web/images/toolbarButton-secondaryToolbarToggle-dark.svg b/web/images/toolbarButton-secondaryToolbarToggle-dark.svg
diff --git a/web/images/toolbarButton-sidebarToggle-dark.svg b/web/images/toolbarButton-sidebarToggle-dark.svg
diff --git a/web/images/toolbarButton-viewAttachments-dark.svg b/web/images/toolbarButton-viewAttachments-dark.svg
diff --git a/web/images/toolbarButton-viewLayers-dark.svg b/web/images/toolbarButton-viewLayers-dark.svg
diff --git a/web/images/toolbarButton-viewOutline-dark.svg b/web/images/toolbarButton-viewOutline-dark.svg
diff --git a/web/images/toolbarButton-viewThumbnail-dark.svg b/web/images/toolbarButton-viewThumbnail-dark.svg
diff --git a/web/images/toolbarButton-zoomIn-dark.svg b/web/images/toolbarButton-zoomIn-dark.svg
diff --git a/web/images/toolbarButton-zoomOut-dark.svg b/web/images/toolbarButton-zoomOut-dark.svg
diff --git a/web/images/treeitem-collapsed-dark.svg b/web/images/treeitem-collapsed-dark.svg
diff --git a/web/images/treeitem-expanded-dark.svg b/web/images/treeitem-expanded-dark.svg