[JS] Formatted value has to be a string when neither null nor undefined

mozilla · May 8, 2022 · ab3958d · ab3958d
1 parent cfac6fa
commit ab3958d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/core/annotation.js b/src/core/annotation.js
@@ -1532,6 +1532,8 @@ class WidgetAnnotation extends Annotation {
       }
     }
 
+    assert(typeof value === "string", "Expected `value` to be a string.");
+
     value = value.trim();
 
     if (value === "") {

diff --git a/src/scripting_api/event.js b/src/scripting_api/event.js
@@ -191,7 +191,7 @@ class EventDispatcher {
       let formattedValue = null;
 
       if (this.runActions(source, source, event, "Format")) {
-        formattedValue = event.value;
+        formattedValue = event.value?.toString?.();
       }
 
       source.obj._send({
@@ -296,7 +296,7 @@ class EventDispatcher {
       savedValue = event.value = target.obj.value;
       let formattedValue = null;
       if (this.runActions(target, target, event, "Format")) {
-        formattedValue = event.value;
+        formattedValue = event.value?.toString?.();
       }
 
       target.obj._send({
-Original file line number
+Diff line change
@@ Expand Up / @@ -1532,6 +1532,8 @@ class WidgetAnnotation extends Annotation { @@
           }
         }
+        assert(typeof value === "string", "Expected `value` to be a string.");
         value = value.trim();
         if (value === "") {
@@ Expand Down @@