Skip to content

Commit

Permalink
Call done.fail correctly in the scripting_spec.js unit-tests
Browse files Browse the repository at this point in the history
The `done.fail` method should *always* be called with a reason, to ensure that any errors are propagated as intended to the test results.
  • Loading branch information
Snuffleupagus committed Dec 12, 2020
1 parent d1848f5 commit 9adb225
Showing 1 changed file with 18 additions and 18 deletions.
36 changes: 18 additions & 18 deletions test/unit/scripting_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -749,8 +749,8 @@ describe("Scripting", function () {
});

done();
} catch (_) {
done.fail();
} catch (ex) {
done.fail(ex);
}
});
});
Expand Down Expand Up @@ -793,8 +793,8 @@ describe("Scripting", function () {
valueAsString: "123456.789",
});
done();
} catch (_) {
done.fail();
} catch (ex) {
done.fail(ex);
}
});

Expand Down Expand Up @@ -834,8 +834,8 @@ describe("Scripting", function () {
value: "Invalid number in [ MyField ]",
});
done();
} catch (_) {
done.fail();
} catch (ex) {
done.fail(ex);
}
});
});
Expand Down Expand Up @@ -893,8 +893,8 @@ describe("Scripting", function () {
});

done();
} catch (_) {
done.fail();
} catch (ex) {
done.fail(ex);
}
});
});
Expand Down Expand Up @@ -948,8 +948,8 @@ describe("Scripting", function () {
});

done();
} catch (_) {
done.fail();
} catch (ex) {
done.fail(ex);
}
});
});
Expand Down Expand Up @@ -990,8 +990,8 @@ describe("Scripting", function () {
});

done();
} catch (_) {
done.fail();
} catch (ex) {
done.fail(ex);
}
});

Expand Down Expand Up @@ -1029,8 +1029,8 @@ describe("Scripting", function () {
});

done();
} catch (_) {
done.fail();
} catch (ex) {
done.fail(ex);
}
});
});
Expand Down Expand Up @@ -1124,8 +1124,8 @@ describe("Scripting", function () {
});

done();
} catch (_) {
done.fail();
} catch (ex) {
done.fail(ex);
}
});
});
Expand Down Expand Up @@ -1202,8 +1202,8 @@ describe("Scripting", function () {
});

done();
} catch (_) {
done.fail();
} catch (ex) {
done.fail(ex);
}
});
});
Expand Down

0 comments on commit 9adb225

Please sign in to comment.