-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure that matches are not scrolled into after the findbar has been …
…closed (PR 10100 follow-up) Despite all highlighted matches being removed in response to the 'findbarclose' event, there's a risk that a match could still be scrolled into view *after* the findbar has been closed[1]. Hence we need to ensure that long running searches, particularily those happening in large and/or slow loading documents[2], are ignored as well. --- [1] The match is hidden, as expected, but the document could still scroll unexpectedly. [2] Large documents loaded with `disableAutoFetch = true` and `disableStream = true` set are particularily susceptible to this issue.
- Loading branch information
1 parent
27b21f2
commit 99b263f
Showing
1 changed file
with
17 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters