Skip to content

Commit

Permalink
fix reftests after #12107
Browse files Browse the repository at this point in the history
The f1040-annotations reftest started hanging after #12107. We traced
this to `TypeError: can't access property "getOrCreateValue", storage is
undefined`.

We essentially need to add `annotationStorage` to the parameters in
test/driver.js.
  • Loading branch information
escapewindow committed Jul 30, 2020
1 parent eb4d6a0 commit 7bb65ba
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/pdf.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ import {
VerbosityLevel,
} from "./shared/util.js";
import { AnnotationLayer } from "./display/annotation_layer.js";
import { AnnotationStorage } from "./display/annotation_storage.js";
import { apiCompatibilityParams } from "./display/api_compatibility.js";
import { GlobalWorkerOptions } from "./display/worker_options.js";
import { renderTextLayer } from "./display/text_layer.js";
Expand Down Expand Up @@ -156,6 +157,8 @@ export {
VerbosityLevel,
// From "./display/annotation_layer.js":
AnnotationLayer,
// From "./display/annotation_storage.js":
AnnotationStorage,
// From "./display/api_compatibility.js":
apiCompatibilityParams,
// From "./display/worker_options.js":
Expand Down
1 change: 1 addition & 0 deletions test/driver.js
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ var rasterizeAnnotationLayer = (function rasterizeAnnotationLayerClosure() {
linkService: new pdfjsViewer.SimpleLinkService(),
imageResourcesPath,
renderInteractiveForms,
annotationStorage: new pdfjsLib.AnnotationStorage(),
};
pdfjsLib.AnnotationLayer.render(parameters);

Expand Down

0 comments on commit 7bb65ba

Please sign in to comment.