Skip to content

Commit

Permalink
Stop defining the defaultUrl-option in the MOZCENTRAL viewer
Browse files Browse the repository at this point in the history
This option is not used, nor has it ever been used, in the *built-in* Firefox PDF Viewer. Hence we can define it only for the environments where it makes sense instead.
  • Loading branch information
Snuffleupagus committed Jun 18, 2022
1 parent abcc32a commit 77aa86e
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions web/app_options.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,6 @@ const defaultOptions = {
value: 0,
kind: OptionKind.VIEWER + OptionKind.PREFERENCE,
},
defaultUrl: {
/** @type {string} */
value: "compressed.tracemonkey-pldi-09.pdf",
kind: OptionKind.VIEWER,
},
defaultZoomValue: {
/** @type {string} */
value: "",
Expand Down Expand Up @@ -296,6 +291,11 @@ if (
typeof PDFJSDev === "undefined" ||
PDFJSDev.test("!PRODUCTION || GENERIC")
) {
defaultOptions.defaultUrl = {
/** @type {string} */
value: "compressed.tracemonkey-pldi-09.pdf",
kind: OptionKind.VIEWER,
};
defaultOptions.disablePreferences = {
/** @type {boolean} */
value: typeof PDFJSDev !== "undefined" && PDFJSDev.test("TESTING"),
Expand All @@ -320,6 +320,11 @@ if (

defaultOptions.renderer.kind += OptionKind.PREFERENCE;
} else if (PDFJSDev.test("CHROME")) {
defaultOptions.defaultUrl = {
/** @type {string} */
value: "",
kind: OptionKind.VIEWER,
};
defaultOptions.disableTelemetry = {
/** @type {boolean} */
value: false,
Expand Down

0 comments on commit 77aa86e

Please sign in to comment.