Merge pull request #12372 from Snuffleupagus/skip-FBF-makeref

Skip failing FBF tests, when running `makeref`, in Firefox as well
mozilla · Sep 13, 2020 · 741ce4f · 741ce4f
2 parents b058266 + 1876744
commit 741ce4f
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/test/test.js b/test/test.js
@@ -467,9 +467,14 @@ function checkFBF(task, results, browser, masterMode) {
       continue;
     }
     if (r0Page.snapshot !== r1Page.snapshot) {
-      // The FBF tests fail intermittently in Google Chrome when run on the
-      // bots, ignoring `makeref` failures for now; see https://github.com/mozilla/pdf.js/pull/11491
-      if (masterMode && /chrom(e|ium)/i.test(browser)) {
+      // The FBF tests fail intermittently in Firefox and Google Chrome when run
+      // on the bots, ignoring `makeref` failures for now; see
+      //  - https://github.com/mozilla/pdf.js/pull/12368
+      //  - https://github.com/mozilla/pdf.js/pull/11491
+      //
+      // TODO: Figure out why this happens, so that we can remove the hack; see
+      //       https://github.com/mozilla/pdf.js/issues/12371
+      if (masterMode) {
         console.log(
           "TEST-SKIPPED | forward-back-forward test " +
             task.id +