Merge pull request #16612 from erm1116/fix-contentscript-updateEmbedE…

…lement Fix reading property of null object in chrome extension's updateEmbedElement function
mozilla · Jul 1, 2023 · 73b6ee5 · 73b6ee5
2 parents 8a95482 + fcf38f6
commit 73b6ee5
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/extensions/chromium/contentscript.js b/extensions/chromium/contentscript.js
@@ -132,8 +132,12 @@ function updateEmbedElement(elem) {
   }
   elem.type = "text/html";
   elem.src = getEmbeddedViewerURL(elem.src);
+
   if (parentNode) {
-    nextSibling.before(elem);
+    // Suppress linter warning: insertBefore is preferable to
+    // nextSibling.before(elem) because nextSibling may be null.
+    // eslint-disable-next-line unicorn/prefer-modern-dom-apis
+    parentNode.insertBefore(elem, nextSibling);
   }
 }