Skip to content

Commit

Permalink
Merge pull request #12369 from emilio/better-cancelation-follow-up
Browse files Browse the repository at this point in the history
canvas: fix restore() with existing SMask groups and re-land #12363.
  • Loading branch information
timvandermeij authored Sep 15, 2020
2 parents 374aad7 + bf8b1ad commit 558d387
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions src/display/canvas.js
Original file line number Diff line number Diff line change
Expand Up @@ -1009,8 +1009,8 @@ var CanvasGraphics = (function CanvasGraphicsClosure() {

endDrawing: function CanvasGraphics_endDrawing() {
// Finishing all opened operations such as SMask group painting.
if (this.current.activeSMask !== null) {
this.endSMaskGroup();
while (this.stateStack.length || this.current.activeSMask !== null) {
this.restore();
}

this.ctx.restore();
Expand Down Expand Up @@ -1192,7 +1192,7 @@ var CanvasGraphics = (function CanvasGraphicsClosure() {
groupCtx.clearRect(0, 0, groupCtx.canvas.width, groupCtx.canvas.height);
groupCtx.restore();
},
resumeSMaskGroup: function CanvasGraphics_endSMaskGroup() {
resumeSMaskGroup: function CanvasGraphics_resumeSMaskGroup() {
// Resuming state saved by suspendSMaskGroup. We don't need to restore
// any groupCtx state since restore() command (the only caller) will do
// that for us. See also beginSMaskGroup.
Expand Down Expand Up @@ -1254,6 +1254,9 @@ var CanvasGraphics = (function CanvasGraphicsClosure() {
this.pendingClip = null;

this._cachedGetSinglePixelWidth = null;
} else {
// We've finished all the SMask groups, reflect that in our state.
this.current.activeSMask = null;
}
},
transform: function CanvasGraphics_transform(a, b, c, d, e, f) {
Expand Down

0 comments on commit 558d387

Please sign in to comment.