Skip to content

Commit

Permalink
Alwaws remove the sidebarMoving CSS class when the sidebar is closed
Browse files Browse the repository at this point in the history
When the viewer becomes narrow enough that the sidebar is overlaying the document, which means that the `viewerContainer` is not moving then opening/closing the sidebar, we're currently not removing the `sidebarMoving` CSS class as intended.
While this doesn't cause any *visible* issues, it's nonetheless wrong and should be fixed.
  • Loading branch information
Snuffleupagus committed Apr 11, 2022
1 parent 143ba30 commit 4edf7d6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions web/pdf_sidebar.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ const UI_NOTIFICATION_CLASS = "pdfSidebarNotification";
* @typedef {Object} PDFSidebarElements
* @property {HTMLDivElement} outerContainer - The outer container
* (encasing both the viewer and sidebar elements).
* @property {HTMLDivElement} viewerContainer - The viewer container
* (in which the viewer element is placed).
* @property {HTMLDivElement} sidebarContainer - The sidebar container
* (in which the views are placed).
* @property {HTMLButtonElement} toggleButton - The button used for
* opening/closing the sidebar.
* @property {HTMLButtonElement} thumbnailButton - The button used to show
Expand Down Expand Up @@ -79,7 +79,7 @@ class PDFSidebar {
this.pdfThumbnailViewer = pdfThumbnailViewer;

this.outerContainer = elements.outerContainer;
this.viewerContainer = elements.viewerContainer;
this.sidebarContainer = elements.sidebarContainer;
this.toggleButton = elements.toggleButton;

this.thumbnailButton = elements.thumbnailButton;
Expand Down Expand Up @@ -369,8 +369,8 @@ class PDFSidebar {
* @private
*/
_addEventListeners() {
this.viewerContainer.addEventListener("transitionend", evt => {
if (evt.target === this.viewerContainer) {
this.sidebarContainer.addEventListener("transitionend", evt => {
if (evt.target === this.sidebarContainer) {
this.outerContainer.classList.remove("sidebarMoving");
}
});
Expand Down
2 changes: 1 addition & 1 deletion web/viewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ function getViewerConfiguration() {
sidebar: {
// Divs (and sidebar button)
outerContainer: document.getElementById("outerContainer"),
viewerContainer: document.getElementById("viewerContainer"),
sidebarContainer: document.getElementById("sidebarContainer"),
toggleButton: document.getElementById("sidebarToggle"),
// Buttons
thumbnailButton: document.getElementById("viewThumbnail"),
Expand Down

0 comments on commit 4edf7d6

Please sign in to comment.