Skip to content

Commit

Permalink
JS -- Plug PageOpen and PageClose actions
Browse files Browse the repository at this point in the history
  • Loading branch information
calixteman committed Jan 5, 2021
1 parent ed3758f commit 1ede46a
Show file tree
Hide file tree
Showing 5 changed files with 175 additions and 16 deletions.
5 changes: 2 additions & 3 deletions src/display/api.js
Original file line number Diff line number Diff line change
Expand Up @@ -1136,9 +1136,8 @@ class PDFPageProxy {
}

/**
* @param {GetAnnotationsParameters} params - Annotation parameters.
* @returns {Promise<Array<any>>} A promise that is resolved with an
* {Array} of the annotation objects.
* @returns {Promise<Object>} A promise that is resolved with an
* {Object} with JS actions.
*/
getJSActions() {
if (!this._jsActionsPromise) {
Expand Down
23 changes: 15 additions & 8 deletions src/scripting_api/doc.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ class Doc extends PDFObject {
this._zoom = data.zoom || 100;
this._actions = createActionsMap(data.actions);
this._globalEval = data.globalEval;
this._pageActions = new Map();
}

_dispatchDocEvent(name) {
Expand All @@ -114,22 +115,28 @@ class Doc extends PDFObject {
}
}

_dispatchPageEvent(name, action, pageNumber) {
_dispatchPageEvent(name, actions, pageNumber) {
if (name === "PageOpen") {
if (!this._pageActions.has(pageNumber)) {
this._pageActions.set(pageNumber, createActionsMap(actions));
}
this._pageNum = pageNumber - 1;
}

this._globalEval(action);
actions = this._pageActions.get(pageNumber)?.get(name);
if (actions) {
for (const action of actions) {
this._globalEval(action);
}
}
}

_runActions(name) {
if (!this._actions.has(name)) {
return;
}

const actions = this._actions.get(name);
for (const action of actions) {
this._globalEval(action);
if (actions) {
for (const action of actions) {
this._globalEval(action);
}
}
}

Expand Down
5 changes: 2 additions & 3 deletions src/scripting_api/event.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,10 @@ class EventDispatcher {
}
if (id === "doc") {
this._document.obj._dispatchDocEvent(event.name);
}
if (id === "page") {
} else if (id === "page") {
this._document.obj._dispatchPageEvent(
event.name,
baseEvent.action,
baseEvent.actions,
baseEvent.pageNumber
);
}
Expand Down
95 changes: 93 additions & 2 deletions test/integration/scripting_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@
const { clearInput, closePages, loadAndWait } = require("./test_utils.js");

describe("Interaction", () => {
async function actAndWaitForInput(page, selector, action) {
await clearInput(page, selector);
async function actAndWaitForInput(page, selector, action, clear = true) {
if (clear) {
await clearInput(page, selector);
}
await action();
await page.waitForFunction(
`document.querySelector("${selector.replace("\\", "\\\\")}").value !== ""`
Expand Down Expand Up @@ -307,6 +309,18 @@ describe("Interaction", () => {
if (process.platform === "win32" && browserName === "firefox") {
pending("Disabled in Firefox on Windows, because of bug 1662471.");
}
await page.waitForFunction(
"window.PDFViewerApplication.scriptingReady === true"
);

await clearInput(page, "#\\34 7R");
await page.evaluate(_ => {
window.document.activeElement.blur();
});
await page.waitForFunction(
`document.querySelector("#\\\\34 7R").value === ""`
);

let text = await actAndWaitForInput(page, "#\\34 7R", async () => {
await page.click("#print");
});
Expand Down Expand Up @@ -337,6 +351,10 @@ describe("Interaction", () => {
it("must execute WillSave and DidSave actions", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
await page.waitForFunction(
"window.PDFViewerApplication.scriptingReady === true"
);

try {
// Disable download in chrome
// (it leads to an error in firefox so the try...)
Expand All @@ -345,6 +363,13 @@ describe("Interaction", () => {
});
} catch (_) {}
await clearInput(page, "#\\34 7R");
await page.evaluate(_ => {
window.document.activeElement.blur();
});
await page.waitForFunction(
`document.querySelector("#\\\\34 7R").value === ""`
);

let text = await actAndWaitForInput(page, "#\\34 7R", async () => {
await page.click("#download");
});
Expand All @@ -360,4 +385,70 @@ describe("Interaction", () => {
);
});
});

describe("in doc_actions.pdf for page actions", () => {
let pages;

beforeAll(async () => {
pages = await loadAndWait("doc_actions.pdf", "#\\34 7R");
});

afterAll(async () => {
await closePages(pages);
});

it("must execute PageOpen and PageClose actions", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
await page.waitForFunction(
"window.PDFViewerApplication.scriptingReady === true"
);

let text = await page.$eval("#\\34 7R", el => el.value);
expect(text).withContext(`In ${browserName}`).toEqual("PageOpen 1");

for (let run = 0; run < 2; run++) {
for (const ref of [18, 19, 20, 21, 47, 50]) {
await page.evaluate(refElem => {
const element = window.document.getElementById(`${refElem}R`);
if (element) {
element.value = "";
}
}, ref);
}

for (const [refOpen, refClose, pageNumOpen, pageNumClose] of [
[18, 50, 2, 1],
[21, 19, 3, 2],
[47, 20, 1, 3],
]) {
text = await actAndWaitForInput(
page,
`#\\3${Math.floor(refOpen / 10)} ${refOpen % 10}R`,
async () => {
await page.evaluate(refElem => {
window.document
.getElementById(`${refElem}R`)
.scrollIntoView();
}, refOpen);
},
false
);
expect(text)
.withContext(`In ${browserName}`)
.toEqual(`PageOpen ${pageNumOpen}`);

text = await page.$eval(
`#\\3${Math.floor(refClose / 10)} ${refClose % 10}R`,
el => el.value
);
expect(text)
.withContext(`In ${browserName}`)
.toEqual(`PageClose ${pageNumClose}`);
}
}
})
);
});
});
});
63 changes: 63 additions & 0 deletions web/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -1542,6 +1542,67 @@ const PDFViewerApplication = {
};
internalEvents.set("updatefromsandbox", updateFromSandbox);

const lastOpenPages = new Map();
const visitedPages = new Map();
const pageOpen = async ({ pageNumber }) => {
lastOpenPages.set(
pageNumber,
new Promise(resolveLastPage => {
if (!visitedPages.has(pageNumber)) {
const promise = new Promise(resolve => {
const pageView = this.pdfViewer.getPageView(
/* index = */ pageNumber - 1
);
if (pageView?.pdfPage) {
pageView.pdfPage.getJSActions().then(resolve);
return;
}
pdfDocument.getPage(pageNumber).then(pdfPage => {
pdfPage.getJSActions().then(resolve);
});
});
visitedPages.set(pageNumber, promise);
}
visitedPages.get(pageNumber).then(actions => {
if (actions !== null) {
// Send actions only the first time the page is visited
visitedPages.set(pageNumber, Promise.resolve(null));
}

if (pdfDocument !== this.pdfDocument) {
return; // The document was closed while the actions resolved.
}

this._scriptingInstance?.scripting.dispatchEventInSandbox({
id: "page",
name: "PageOpen",
pageNumber,
actions,
});

resolveLastPage();
});
})
);
await lastOpenPages.get(pageNumber);
};

const pageClose = async ({ pageNumber }) => {
const promise = lastOpenPages.get(pageNumber);
if (!promise) {
return;
}
lastOpenPages.delete(pageNumber);
await promise;
this._scriptingInstance?.scripting.dispatchEventInSandbox({
id: "page",
name: "PageClose",
pageNumber,
});
};
internalEvents.set("pageopen", pageOpen);
internalEvents.set("pageclose", pageClose);

const dispatchEventInSandbox = ({ detail }) => {
scripting.dispatchEventInSandbox(detail);
};
Expand Down Expand Up @@ -1613,6 +1674,8 @@ const PDFViewerApplication = {
name: "Open",
});

await pageOpen({ pageNumber: this.pdfViewer.currentPageNumber });

// Used together with the integration-tests, see the `scriptingReady`
// getter, to enable awaiting full initialization of the scripting/sandbox.
// (Defer this slightly, to make absolutely sure that everything is done.)
Expand Down

0 comments on commit 1ede46a

Please sign in to comment.