Skip to content

Commit

Permalink
[Firefox] Stop logging RenderingCancelledExceptions as errors when …
Browse files Browse the repository at this point in the history
…printing

In the rest of the viewer code-base, we purposely don't treat `RenderingCancelledException`s as actual errors (since they aren't) and consequently we never log them.
Hence it makes sense, as far as I'm concerned, to simply treat `RenderingCancelledException`s the same way when printing in Firefox.

While I don't print a whole lot, I cannot remember seeing these "errors" logged when printing until *very* recently[1]. Given that the browser print functionality and UI, in Firefox, is under active development it's certainly possible that there's some recent changes to the related timings which make `RenderingCancelledException`s more likely now.

---
[1] Interestingly, only some PDF documents seem to be affected as well; I'm able to reproduce this pretty consistently by opening https://www.uni-muenster.de/imperia/md/content/ziv/pdf/printpay_flyer.pdf in Firefox and then repeating the following sequence:
Clicking on the PDF.js print button, and then cancelling printing.
  • Loading branch information
Snuffleupagus committed Oct 4, 2020
1 parent 910772c commit 069ddc8
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions web/firefox_print_service.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
* limitations under the License.
*/

import { RenderingCancelledException, shadow } from "pdfjs-lib";
import { CSS_UNITS } from "./ui_utils.js";
import { PDFPrintServiceFactory } from "./app.js";
import { shadow } from "pdfjs-lib";

// Creates a placeholder with div and canvas with right size for the page.
function composePage(
Expand Down Expand Up @@ -85,8 +85,10 @@ function composePage(
}
obj.done();
},
function (error) {
console.error(error);
function (reason) {
if (!(reason instanceof RenderingCancelledException)) {
console.error(reason);
}

if (currentRenderTask === thisRenderTask) {
currentRenderTask.cancel();
Expand Down

0 comments on commit 069ddc8

Please sign in to comment.