Merge pull request #12364 from calixteman/really_fix_name_issue

Dict keys need to be escaped too when saving
mozilla · Sep 11, 2020 · 008eed0 · 008eed0
2 parents aef3fed + fc15459
commit 008eed0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/core/writer.js b/src/core/writer.js
@@ -23,7 +23,7 @@ import { calculateMD5 } from "./crypto.js";
 function writeDict(dict, buffer, transform) {
   buffer.push("<<");
   for (const key of dict.getKeys()) {
-    buffer.push(` /${key} `);
+    buffer.push(` /${escapePDFName(key)} `);
     writeValue(dict.getRaw(key), buffer, transform);
   }
   buffer.push(">>");

diff --git a/test/unit/writer_spec.js b/test/unit/writer_spec.js
@@ -98,14 +98,14 @@ describe("Writer", function () {
 
     it("should write a Dict in escaping PDF names", function (done) {
       const dict = new Dict(null);
-      dict.set("A", Name.get("hello"));
+      dict.set("\xfeA#", Name.get("hello"));
       dict.set("B", Name.get("#hello"));
       dict.set("C", Name.get("he\xfello\xff"));
 
       const buffer = [];
       writeDict(dict, buffer, null);
 
-      const expected = "<< /A /hello /B /#23hello /C /he#fello#ff>>";
+      const expected = "<< /#feA#23 /hello /B /#23hello /C /he#fello#ff>>";
 
       expect(buffer.join("")).toEqual(expected);
       done();