-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for strict type check comparisons #746
Conversation
This is a departure from Jinja2 syntax, which normally I would prefer not to do, but in this case I buy that it's necessary; |
If I were implementing nunjucks from scratch, I would be awfully tempted to have |
Why not in a new major version? |
@ricordisamoa I'm open to that, if you want to open a ticket for it and put it in the 3.0 milestone. Hmm... I guess if we plan to do that, it might be better not to merge this? It would be silly to end up in a situation where we support both On the other hand, if it's in 3.0 we can always just drop |
Add support for strict type check comparisons
@carljm, thanks for going over my changes. I understand the Jinja2 influence and desire not to stray from that. I hope that a benefit from this new functionality is a lower barrier to adoption for swig users looking to migrate their templates since swig is no longer maintained. Nunjucks seems like the natural choice for migrating swig templates, and swig has strict type checking. I’m in the process of migrating some swig templates to nunjucks and ran into |
|
There is a typo in release notes:
I also hope that #750 is still valid for 3.0.0 version? |
I added support for the
===
and!==
comparison operators.