Make each nunjucks environment have its own globals property #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test case to check for this. - Update util.js's equal method to take in an optional env parameter, since globals aren't shared between environments anymore. - Update Context in src/environment.js to take in optional env parameter, for same reason.
|
Looks great! Can you also add a note to the CHANGELOG file? Thanks! |
|
Done. Thanks for the quick review. |
|
Had to fix conflicts with PR #575, which was merged into master. carljm, is there anything else I need to do before this can be merged into master? |
|
Nope, looks good, merging! Sorry, must have missed the email notification on your update. |
carljm
added a commit
that referenced
this pull request
Nov 6, 2015
Make each nunjucks environment have its own globals property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the shared globals between environments issue mentioned in #573. Let me know if you'd like me to revise anything.
Here's what's included:
Thanks!