Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

[Enhancement] Text caret should appear in the sidebar when you click the "New Note" button #833

Closed
Softvision-CristinaBadescu opened this issue Mar 28, 2018 · 6 comments
Assignees
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@Softvision-CristinaBadescu

[Affected versions]:

  • Firefox 59.0.2 and above

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • Have a Firefox profile with the latest version of the "Firefox Notes" add-on (3.2.0dev) installed.
  • Have Firefox Notes sidebar open.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites.
  2. Click the "New Note" button and type something.

[Expected result]:

  • The text is displayed.

[Actual result]:

  • No text is written.

[Notes]:

  • You need to click inside the sidebar in order to focus it.
  • Attached a screen recording of the issue:
    firefox notes enhancement
@vladikoff
Copy link
Contributor

Good find! 👍 this would be great to have

@vladikoff vladikoff added this to the Triaged milestone Mar 29, 2018
@vladikoff
Copy link
Contributor

@sebastienbarbier let's see if we can do this for v4. We couldn't focus the editor on sidebar-open before but it might work with React views

vladikoff added a commit that referenced this issue Apr 3, 2018
vladikoff added a commit that referenced this issue Apr 3, 2018
@Softvision-CristinaBadescu
Copy link
Author

This issue is no longer reproducible using Firefox Notes v3.2.0dev (custom built on 2018-04-03), on latest Nightly build 61.0a1 (2018-04-02), on Windows 10 x64, Mac 10.13.3 and Ubuntu 14.04 x64.

However, this issue is reproducible if you create a new note, using the "New Note" button, from an open note. Considering this, I'm going to reopen this issue.
notes - text caret from a note

@vladikoff
Copy link
Contributor

Good find! we might be able to fix that

vladikoff pushed a commit that referenced this issue Apr 3, 2018
* Use ckeditor API to setFocus and solve some UI issue
* SetFocus on new Note from existing note

Fixes #869 
Fixes #833
@Softvision-CristinaBadescu
Copy link
Author

Thanks for fixing this! The issue is no longer reproducible using Firefox Notes v3.2.0dev (custom built on 2018-04-04), on latest Nightly build 61.0a1 (2018-04-04), on Windows 10 x64, Mac 10.13.3 and Ubuntu 14.04 x64.

@vladikoff
Copy link
Contributor

Yay!

@Softvision-CristinaBadescu Softvision-CristinaBadescu added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

3 participants