Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Google Cloud Storage in addition to S3 #1566

Closed
sciurus opened this issue Oct 2, 2018 · 2 comments · Fixed by #1598
Closed

Support Google Cloud Storage in addition to S3 #1566

sciurus opened this issue Oct 2, 2018 · 2 comments · Fixed by #1598
Labels
gcp

Comments

@sciurus
Copy link
Contributor

sciurus commented Oct 2, 2018

Normandy admin currently uploads addons to an S3 bucket. Normandy should support uploading to a GCS bucket as well.

Currently we have an DJANGO_AWS_STORAGE_BUCKET_NAME bucket name. Maybe we could also have a DJANGO_GCS_STORAGE_BUCKET_NAME, and the one that is set determines which storage to use?
@sciurus sciurus added the gcp label Oct 2, 2018
@mythmon
Copy link
Contributor

mythmon commented Oct 3, 2018

Our storages library provides a lot of settings. I think the only one there we will need to expose is GS_BUCKET_NAME (which will be mapped to DJANGO_GS_BUCKET_NAME. @sciurus are there any other setting in that list you will want to set? It is easy to add more later, but it would be nice to start with a useful set.

We'll likely just directly expose more of the library's settings. The result would look like this:

# Set the file storage to Google Cloud
DJANGO_DEFAULT_FILE_STORAGE='storages.backends.gcloud.GoogleCloudStorage'
# Poit to the right bucket
DJANGO_GS_BUCKET_NAME=...

@sciurus
Copy link
Contributor Author

sciurus commented Oct 4, 2018

I think those two will do it!

mythmon added a commit to mythmon/normandy that referenced this issue Oct 5, 2018
@mythmon
Support Google Cloud Storage in addition to S3
d2d4940 
Fixes mozilla#1566
@mythmon mythmon mentioned this issue Oct 5, 2018
Merged
mythmon added a commit to mythmon/normandy that referenced this issue Oct 8, 2018
@mythmon
Support Google Cloud Storage in addition to S3
0497bbd 
Fixes mozilla#1566
bors bot added a commit that referenced this issue Oct 8, 2018
@bors @mythmon
Merge #1572
31f9a76 
1572: Support Google Cloud Storage in addition to S3 r=peterbe,sciurus a=mythmon

Fixes #1566

Co-authored-by: Mike Cooper <[email protected]>
@bors bors bot closed this as completed in #1572 Oct 8, 2018
@sciurus sciurus mentioned this issue Oct 24, 2018
Merged
bors bot added a commit that referenced this issue Oct 24, 2018
@bors @sciurus
Merge #1598
fd71918 
1598: Fix name of setting for gcs bucket r=mythmon a=sciurus

It should be GS_BUCKET_NAME according to the documentation at https://django-storages.readthedocs.io/en/latest/backends/gcloud.html

This will hopefully fix #1566 

Co-authored-by: Brian Pitts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gcp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix name of setting for gcs bucket mozilla/normandy
2 participants
@mythmon @sciurus