Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Firefox Channel field to Audience #60

Closed
jaredlockhart opened this issue Jul 9, 2020 · 0 comments
Closed

Add Firefox Channel field to Audience #60

jaredlockhart opened this issue Jul 9, 2020 · 0 comments
Assignees
@jaredlockhart
Labels
data Changes to the data contained here
Milestone
v0.0.6

Comments

@jaredlockhart
Copy link
Contributor

For Experimenter to know what channel an audience targets, it needs to appear on a specific firefox_channel that includes a string, for instance the list of constants found here:

https://github.com/mozilla/experimenter/blob/main/app/experimenter/experiments/constants.py#L191-L193
@jaredlockhart jaredlockhart mentioned this issue Jul 9, 2020
Merged
@mythmon mythmon added this to the v0.0.5 milestone Jul 10, 2020
@jaredlockhart jaredlockhart mentioned this issue Jul 14, 2020
Closed
jaredlockhart added a commit to JaredLockhart-Mozilla/nimbus-shared that referenced this issue Jul 14, 2020
@jaredlockhart
Add firefox channel to audiences fixes mozilla#60
f8c35d9
@mythmon mythmon added the data Changes to the data contained here label Jul 14, 2020
jaredlockhart added a commit that referenced this issue Jul 15, 2020
@jaredlockhart
Merge pull request #77 from JaredLockhart-Mozilla/60
04c936a 
Add firefox channel to audiences fixes #60
@jaredlockhart jaredlockhart self-assigned this Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredlockhart jaredlockhart

Labels
data Changes to the data contained here
Projects
None yet
Milestone
v0.0.6
Development

No branches or pull requests
2 participants
@jaredlockhart @mythmon