chore: Guard testing functions properly #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a bunch of functions that in their doc comments say that they are for testing purposes only. This commit adds guards to those functions to make sure they are not used in production code.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2264 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 113 113
Lines 36683 36683
=======================================
+ Hits 34993 34994 +1
+ Misses 1690 1689 -1 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 9143d73. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 9143d73. decode 4096 bytes, mask ff: No change in performance detected. time: [15.850 µs 15.895 µs 15.946 µs]
change: [-0.3443% +0.0997% +0.5489%] (p = 0.66 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [4.0530 ms 4.0649 ms 4.0786 ms]
change: [-0.2525% +0.1467% +0.5633%] (p = 0.50 > 0.05)
decode 4096 bytes, mask 7f: Change within noise threshold. time: [26.896 µs 26.964 µs 27.035 µs]
change: [-1.2858% -0.9043% -0.5360%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [6.8887 ms 6.9095 ms 6.9383 ms]
change: [-0.5009% -0.0577% +0.4285%] (p = 0.82 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [12.437 µs 12.482 µs 12.533 µs]
change: [-0.2843% +0.2150% +0.7036%] (p = 0.42 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [3.1835 ms 3.1993 ms 3.2211 ms]
change: [+0.0183% +0.6176% +1.3667%] (p = 0.07 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.555 ns 98.876 ns 99.201 ns]
change: [-0.8423% -0.3746% +0.0509%] (p = 0.10 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.57 ns 116.90 ns 117.25 ns]
change: [-0.5616% -0.1955% +0.1787%] (p = 0.32 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.25 ns 116.70 ns 117.25 ns]
change: [-0.5725% +0.0732% +0.8565%] (p = 0.86 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.146 ns 97.299 ns 97.471 ns]
change: [-0.6287% +0.1268% +0.9059%] (p = 0.77 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.40 ms 111.54 ms 111.75 ms]
change: [-0.2218% +0.0351% +0.2748%] (p = 0.81 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.5545 µs 5.7412 µs 5.9374 µs]
change: [-14.791% -3.3445% +4.9983%] (p = 0.71 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [25.671 ms 26.771 ms 27.891 ms]
change: [-7.1348% -2.2203% +3.2224%] (p = 0.40 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [33.852 ms 35.528 ms 37.214 ms]
change: [-5.8853% +0.1557% +7.1992%] (p = 0.97 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [24.937 ms 25.745 ms 26.556 ms]
change: [-1.8407% +2.2995% +6.9377%] (p = 0.32 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [38.684 ms 40.541 ms 42.403 ms]
change: [-10.289% -4.4660% +2.0599%] (p = 0.18 > 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved. time: [858.51 ms 867.59 ms 876.83 ms]
thrpt: [114.05 MiB/s 115.26 MiB/s 116.48 MiB/s]
change:
time: [-8.7753% -7.3972% -5.8580%] (p = 0.00 < 0.05)
thrpt: [+6.2225% +7.9881% +9.6194%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [314.30 ms 317.55 ms 320.84 ms]
thrpt: [31.168 Kelem/s 31.491 Kelem/s 31.816 Kelem/s]
change:
time: [-1.5298% -0.1924% +1.1814%] (p = 0.79 > 0.05)
thrpt: [-1.1676% +0.1928% +1.5536%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [33.567 ms 33.731 ms 33.892 ms]
thrpt: [29.506 elem/s 29.647 elem/s 29.791 elem/s]
change:
time: [-1.4397% -0.6429% +0.0557%] (p = 0.09 > 0.05)
thrpt: [-0.0557% +0.6471% +1.4607%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [1.6696 s 1.6903 s 1.7110 s]
thrpt: [58.444 MiB/s 59.160 MiB/s 59.896 MiB/s]
change:
time: [-0.3879% +1.4306% +3.2599%] (p = 0.12 > 0.05)
thrpt: [-3.1570% -1.4105% +0.3894%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bunch of functions that in their doc comments say that they are for testing purposes only. This commit adds guards to those functions to make sure they are not used in production code.