fix: Don't stop handler if there is no resumption token #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s2n-quic doesn't send a resumption token for the second connection in the QNS `resumption` test, and this caused us to fail.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2067 +/- ##
==========================================
- Coverage 95.35% 95.32% -0.04%
==========================================
Files 112 112
Lines 36505 36505
==========================================
- Hits 34810 34799 -11
- Misses 1695 1706 +11 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 13237c3. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.294 ns 99.620 ns 99.948 ns]
change: [-0.2860% +0.2655% +0.9013%] (p = 0.40 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.41 ns 117.79 ns 118.18 ns]
change: [-0.6693% -0.1025% +0.3712%] (p = 0.72 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [117.13 ns 118.35 ns 120.27 ns]
change: [+0.1024% +0.9123% +1.9533%] (p = 0.07 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.422 ns 97.547 ns 97.689 ns]
change: [-0.1826% +0.4283% +1.0041%] (p = 0.17 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.17 ms 111.31 ms 111.53 ms]
change: [-0.0388% +0.1069% +0.3033%] (p = 0.29 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.596 ms 27.550 ms 28.484 ms]
change: [-3.5720% +1.0238% +6.2261%] (p = 0.70 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [35.006 ms 36.638 ms 38.317 ms]
change: [-6.6642% -0.9110% +4.9285%] (p = 0.77 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [32.376 ms 33.004 ms 33.621 ms]
change: [-3.3432% -0.3427% +2.6651%] (p = 0.82 > 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [42.996 ms 45.679 ms 48.294 ms]
change: [+0.9089% +11.530% +23.595%] (p = 0.03 < 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [114.14 ms 114.49 ms 114.83 ms]
thrpt: [870.88 MiB/s 873.45 MiB/s 876.08 MiB/s]
change:
time: [-0.3733% +0.0293% +0.4672%] (p = 0.90 > 0.05)
thrpt: [-0.4650% -0.0293% +0.3746%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [311.56 ms 315.05 ms 318.56 ms]
thrpt: [31.391 Kelem/s 31.741 Kelem/s 32.096 Kelem/s]
change:
time: [-1.0612% +0.4657% +2.0990%] (p = 0.57 > 0.05)
thrpt: [-2.0558% -0.4636% +1.0726%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [40.029 ms 40.740 ms 41.460 ms]
thrpt: [24.120 elem/s 24.546 elem/s 24.982 elem/s]
change:
time: [-3.0652% -0.7598% +1.6723%] (p = 0.54 > 0.05)
thrpt: [-1.6448% +0.7656% +3.1621%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
KershawChang
approved these changes
Aug 21, 2024
martinthomson
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s2n-quic doesn't send a resumption token for the second connection in the QNS
resumptiontest, and this caused us to fail.