This repository has been archived by the owner on Sep 22, 2020. It is now read-only.
Node update #395
Merged
Node update #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2018 00:57
|
ugh, I'll fix the travis errors |
|
@gideonthomas poke |
|
@cadecairos sorry, I'll try to get to this sometime this week. Until then would you be able to take one final look at the id patch: mozilla/id.webmaker.org#447 |
|
got any time to invest on this in the next little while @gideonthomas? |
|
yeah, the creator patch for pulse was the biggest issue that needed to be fixed. I have one small follow-up to do and then I can revisit this. |
cadecairos
approved these changes
May 10, 2018
Merged
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will update description when i get a sec. One major change I made was I removed js beautifier because it was breaking everything. I thought we don't really need it but let me know if we do.