Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Optimizely with Convert.com in websites #1311

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

hoosteeno
Copy link
Contributor

We are in the midst of implementing Convert.com as an A/B test provider on www.mozilla.org, and may use it on other websites, too. This PR replaces references to Optimizely in the Websites Privacy Notice with new references to Convert.com. Since the references replaced are not localized, this PR fixes all locales.

Optimizely has not been in use for some time. By the time Convert.com is in use, the opt-out link will be working. Therefore, it is probably safe to make this change now.

@peiying2
Copy link
Collaborator

@hoosteeno
The changes themselves are fine and consistent but:

@hoosteeno
Copy link
Contributor Author

@peiying2 The Optimizely opt-out link will not stop working; it's just a plain link to the homepage. But Optimizely is no longer on our website, so these docs are already out of date.

The Convert opt out link doesn't work now because Convert is not yet on our website. When it is on our website, the link will work.

@peiying2 peiying2 self-requested a review September 11, 2019 22:58
Copy link
Collaborator

@peiying2 peiying2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes.

@hoosteeno hoosteeno force-pushed the convert_not_optimizely branch from f6fd2ce to d60efbc Compare September 12, 2019 16:27
@peiying2
Copy link
Collaborator

@hoosteeno if you are good with the update, let me know if you need me to make the merge in case you can't.

@hoosteeno
Copy link
Contributor Author

I don't have merge access to this repo. @peiying2 , if you can merge, that's very helpful. Thanks!

@peiying2 peiying2 merged commit f877a7f into mozilla:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants